Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip: misc + widgets #6

Closed
wants to merge 18 commits into from
Closed

Conversation

c-cube
Copy link
Contributor

@c-cube c-cube commented Mar 11, 2020

see #5 and others

@c-cube c-cube force-pushed the wip-misc-2020-03-11 branch from 3748f64 to 20949e7 Compare March 11, 2020 20:36
@c-cube c-cube marked this pull request as ready for review March 11, 2020 20:36
@c-cube
Copy link
Contributor Author

c-cube commented Mar 11, 2020

  • improve some widgets (scroll, text) with more key bindings
  • focus can be released (only used in text field for now)
  • useful widgets for unfoldable area, vlist, and vlist + dynamic filter (e.g. search)

@let-def
Copy link
Owner

let-def commented Mar 13, 2020

Thanks, I will merge soon.
About the quit handler: Lwd was designed to be exception-safe (if an exception is raised by user functions, the internal state is still consistent). The idea for quitting was rather to simply raise an exception and catch it in the caller of the mainloop.
However I realize that this might not be very future-proof: Lwd might be exception-safe, but user-code might not. It is a bit unsatisfactory to put that burden on all user code just for the purpose of quitting (even though non-local control flow is quite appropriate in this case). Explicit support for quitting might be a good alternative.

(Also, I want to rethink the resource management part : calls to release handlers could be buffered and delegated to the observer; this would better behavior for monadic bind, I will write more about this later)

@let-def
Copy link
Owner

let-def commented Mar 17, 2020

Merged manually. Thanks.

@let-def let-def closed this Mar 17, 2020
@c-cube c-cube deleted the wip-misc-2020-03-11 branch March 23, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants